Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: moved InputChangeController class from SearchController to its separate file #1530

Merged
merged 1 commit into from
Dec 2, 2024
Merged

chore: moved InputChangeController class from SearchController to its separate file #1530

merged 1 commit into from
Dec 2, 2024

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below move InputChangeController class from SearchController.ts to a separate file.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ericleponner ericleponner requested a review from svienot as a code owner December 2, 2024 14:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.32% 24785 / 32902
🔵 Statements 75.32% 24785 / 32902
🔵 Functions 60.14% 996 / 1656
🔵 Branches 83.86% 4731 / 5641
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/search/SearchController.ts 85.83% 88.88% 80% 85.83% 142-144, 163-164, 178-186, 231-233
src/components/utils/InputChangeController.ts 86.36% 85.71% 100% 86.36% 42-44
Generated in workflow #1486

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

svienot
svienot approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericleponner ericleponner merged commit f2c6072 into main Dec 2, 2024
8 of 9 checks passed
@ericleponner ericleponner deleted the refactor branch December 2, 2024 15:00
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 24.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svienot svienot svienot approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericleponner @swirlds-automation @svienot