Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Contract Details / Contract Bytecode / ABI tab now exposes error message available in api/v1/contracts/call response #1532

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below extract message available in error response returned by api/v1/contracts/call.

Related issue(s):

Fixes #1531

Notes for reviewer:

See call to name() in contract 0.0.5198819 on testnet.

With changes below, ABI looks like this:

image

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…/contracts/call response body.

Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner ericleponner requested a review from svienot as a code owner December 2, 2024 17:46
Copy link

github-actions bot commented Dec 2, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.27% 24791 / 32934
🔵 Statements 75.27% 24791 / 32934
🔵 Functions 59.96% 996 / 1661
🔵 Branches 83.86% 4731 / 5641
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/values/abi/ContractCallBuilder.ts 2.2% 100% 0% 2.2% 32-34, 36-37, 43-50, 52-59, 61-74, 76-79, 81-83, 85-86, 88-108, 110-133, 135-141, 147-156, 159-162, 164, 168-171, 173-177, 179-191
src/schemas/MirrorNodeSchemas.ts 89.77% 65.9% 87.5% 89.77% 324-325, 767, 877-881, 917, 920, 936-937, 940-941, 943-946
src/utils/JSUtils.ts 22.72% 100% 0% 22.72% 22-29, 32-34, 37-39, 42-44
Generated in workflow #1488

Signed-off-by: Eric Le Ponner <[email protected]>
Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@svienot svienot merged commit 0383d8f into main Dec 2, 2024
8 of 9 checks passed
@svienot svienot deleted the 01531_expose_call_error branch December 2, 2024 19:00
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 24.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose error message embedded in api/v1/contracts/call response body in Contract Bytecode / ABI tab
3 participants