Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display information related to HCS-1 content in TopicDetails view #1535

Merged
merged 21 commits into from
Dec 3, 2024
Merged

feat: display information related to HCS-1 content in TopicDetails view #1535

merged 21 commits into from
Dec 3, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Dec 3, 2024 •
edited
Loading

Description:

With these changes:

  • the explorer is able to recognise topic content compliant with the HCS-1 specification. Such encoding can be used for instance to store JSON content representing the metadata of a token, or a media file.
  • the TopicDetails view adds a label to flag the topic as HCS-1 as well as a dedicated HCS-1 Content section.

Related issue(s):

Fixes #1534

Notes for reviewer:

Screenshot 2024-12-03 at 09 42 20 Screenshot 2024-12-03 at 09 42 04

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

svienot added 19 commits December 2, 2024 23:31
@svienot
Add 'Chunk' column in TopicMessageTable.
8cd81dc 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Rename TopicMessageCache to TopicMessageByTimestampCache.
0662f1a 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Add getDataURLType to URLUtils.ts (for further use).
734b7a9 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Add TopicMessageCache (for further use).
c2b48d8 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Add HCSTopicMemo and HCSAssetFragment (for further use).
c121fcf 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Initial support for detecting/displaying ERC-1 topics.
71de296 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
getDataURLType() now returns only the MIME type (not the encoding).
7db528d 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Put HCS-1 Content info as a separate card instead of a section in the…
dd51833 
… top card.

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Add "@bokuweb/zstd-wasm" compression library.
aed132e 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Add HCSAsset and HCSAssetCache components and first stage of HCS-1 su…
e2c4d41 
…pport in TopicDetails.

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Add HCSAsset.getDataURL() (for further use).
ba577db 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Add preview of JSON/image/video HCS-1 content in TopicDetails.
61f7b14 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Extract HCS1 Content section from TopicDetails and add HCSContentSect…
abe8948 
…ion component.

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Preview content of audio HCS1 asset using MediaContent as well.
982cec1 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Add HCSContentSection unit test.
0c47032 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Add default value for arweaveServer argument of TokenMetadataAnalyzer…
cc9b2a8 
… constructor (for compatibility with existing tests).

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Make sure zstd init() is called only once.
d955290 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Remove debug traces.
f68ee25 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Indentation.
ad92c35 
Signed-off-by: Simon Viénot <[email protected]>
@svienot svienot requested a review from ericleponner as a code owner December 3, 2024 08:43
@svienot svienot self-assigned this Dec 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.27% 25030 / 33250
🔵 Statements 75.27% 25030 / 33250
🔵 Functions 60.15% 1007 / 1674
🔵 Branches 83.45% 4767 / 5712
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/token/TokenMetadataAnalyzer.ts 78.53% 83.07% 100% 78.53% 102-104, 106, 144-148, 156-170, 235-236, 253-254, 264-270, 284-285, 287-290, 304-305, 307-310
src/components/topic/HCSContentSection.vue 97.05% 72% 100% 97.05% 148-149, 164
src/components/topic/TopicMessageCell.vue 98.11% 81.25% 100% 98.11% 85
src/components/topic/TopicMessageTable.vue 91.91% 72.72% 33.33% 91.91% 84-86, 131-135
src/pages/TopicDetails.vue 97.18% 84.48% 100% 97.18% 38, 218-219, 223
src/pages/TransactionDetails.vue 99% 94.36% 50% 99% 1, 387, 457-458
src/utils/HCSAssetFragment.ts 84.61% 50% 100% 84.61% 36-37, 44-45
src/utils/HCSTopicMemo.ts 86.66% 50% 100% 86.66% 44-45, 47-48
src/utils/URLUtils.ts 89.41% 87.87% 100% 89.41% 64-65, 102-103, 107-109, 111-112
src/utils/cache/CacheUtils.ts 100% 100% 100% 100%
src/utils/cache/HCSAsset.ts 76.27% 71.42% 75% 76.27% 36-45, 83-84, 86-87
src/utils/cache/HCSAssetCache.ts 45.45% 66.66% 100% 45.45% 40, 42-52
src/utils/cache/TopicMessageByTimestampCache.ts 88.88% 80% 100% 88.88% 42-43
src/utils/cache/TopicMessageCache.ts 0% 0% 0% 0% 1, 26, 28, 34-49, 51-66
Generated in workflow #1494

ericleponner
ericleponner approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
10.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@svienot svienot merged commit 6ddc635 into main Dec 3, 2024
8 of 9 checks passed
@svienot svienot deleted the hcs-1-topics branch December 3, 2024 17:45
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 24.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

Assignees

@svienot svienot

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display information related to HCS-1 content in TopicDetails view
3 participants
@svienot @swirlds-automation @ericleponner