Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: renaming (Hedera, Hashgraph, Swirlds) -> Hiero #1540

Merged
merged 5 commits into from
Dec 4, 2024
Merged

chore: renaming (Hedera, Hashgraph, Swirlds) -> Hiero #1540

merged 5 commits into from
Dec 4, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Dec 4, 2024

Description:

  • These changes rename (hopefully) most of the remaining occurrences of (Hedera, Hashgraph, Swirlds) to Hiero.
  • Notable exceptions, perhaps not exhaustive:
    • copyright notices in all source files, to be addressed later
    • paths for files, repositories, etc... to be addressed later
    • CookiesDialog.vue component, which will be taken care of in a separate PR.

Related issue(s):

Related to #1430

@svienot svienot requested review from ericleponner and a team as code owners December 4, 2024 10:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.28% 25045 / 33265
🔵 Statements 75.28% 25045 / 33265
🔵 Functions 60.15% 1007 / 1674
🔵 Branches 83.45% 4773 / 5719
File CoverageNo changed files found.
Generated in workflow #1497

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 4, 2024
View reviewed changes
chart/templates/deployment.yaml
@@ -52,7 +52,7 @@
nodeSelector: {{ toYaml .Values.nodeSelector | nindent 8 }}
priorityClassName: {{ .Values.priorityClassName }}
securityContext: {{ toYaml .Values.podSecurityContext | nindent 8 }}
serviceAccountName: {{ include "hedera-explorer.serviceAccountName" . }}
serviceAccountName: {{ include "hiero-explorer.serviceAccountName" . }}

Check warning

Code scanning / SonarCloud

Service account permissions should be restricted Medium

Bind this Service Account to RBAC or disable "automountServiceAccountToken". See more on SonarQube Cloud
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

ericleponner
ericleponner approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ericleponner ericleponner merged commit 3de8f5c into main Dec 4, 2024
8 of 9 checks passed
@ericleponner ericleponner deleted the renaming branch December 4, 2024 13:55
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 24.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

@mishomihov00 mishomihov00 mishomihov00 approved these changes

@rbarker-dev rbarker-dev Awaiting requested review from rbarker-dev rbarker-dev is a code owner automatically assigned from hashgraph/platform-ci

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner automatically assigned from hashgraph/release-engineering-managers

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svienot @swirlds-automation @ericleponner @mishomihov00