chore: add configuration for cookies acceptance dialog #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l the display and content of the cookies acceptance dialog. Signed-off-by: Simon Viénot <[email protected]>
Signed-off-by: Simon Viénot <[email protected]>
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
|
🎉 This PR is included in version 24.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The changes below introduce a new
CoreConfig.cookiesDialogContentconfiguration parameter to control the content and appearance of the cookies dialog.Note that if not set, the value of the
googleTagIDparameter is ignored.On the other hand, if
cookiesDialogContentis set, andgoogleTagIDis not, the dialog will be show but will have no other effect (for the time being). This will allow us to use cookies for other features if needed later.Related issue(s):
Related to #1430