Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for core-config.json #1545

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

beeradb
Copy link
Contributor

@beeradb beeradb commented Dec 5, 2024

This PR adds support for core.config.json within the mirror node explorer helm chart.

The default values used were copied from https://github.com/hashgraph/hedera-mirror-node-explorer/blob/main/public/core-config.json

Signed-off-by: beeradb <[email protected]>
@beeradb beeradb requested a review from mishomihov00 December 6, 2024 15:35
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested locally on minikube.

@svienot svienot merged commit 252559d into hashgraph:main Dec 9, 2024
6 of 7 checks passed
ericleponner pushed a commit that referenced this pull request Dec 10, 2024
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 24.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants