-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: page views now use PageFrame as their top component #1552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
…care of TopNavBar. Signed-off-by: Eric Le Ponner <[email protected]>
Signed-off-by: Eric Le Ponner <[email protected]>
Signed-off-by: Eric Le Ponner <[email protected]>
Signed-off-by: Eric Le Ponner <[email protected]>
Signed-off-by: Eric Le Ponner <[email protected]>
720161d
to
b68eadc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
🎉 This PR is included in version 24.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Changes below:
PageFrame
viewPageFrame
as the top component of the all the page viewsTopNavBar
as a child ofPageFrame
Related issue(s):
Fixes #1551
Notes for reviewer:
No semantic change. Only refactoring.
Checklist