Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove "Key Alias" from account view #1553

Merged
merged 1 commit into from
Dec 11, 2024
Merged

feat: remove "Key Alias" from account view #1553

merged 1 commit into from
Dec 11, 2024

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below remove the Key Alias field from Account Details page and adapt unit tests.

image

Related issue(s):

Fixes #1550

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.08% 24832 / 33516
🔵 Statements 74.08% 24832 / 33516
🔵 Functions 57.93% 956 / 1650
🔵 Branches 83.03% 4542 / 5470
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/pages/AccountDetails.vue 39.31% 79.27% 0% 39.31% 1, 27, 29-31, 33-38, 40-49, 51-52, 55-60, 62-85, 87-92, 94-106, 108-112, 115-118, 120-125, 128-129, 131-134, 136-137, 139-140, 143-148, 150, 152-154, 156-168, 170, 172-178, 180-184, 186-190, 192-195, 197, 199-202, 204, 206-209, 211-212, 214-215, 217-223, 225-226, 228-229, 231-236, 238-240, 242-246, 248-250, 252, 255-259, 261-265, 267, 269-272, 274, 276, 278, 280-282, 284-304, 306-312, 314-316, 318-326, 328, 427-433, 436-437, 439, 482-483, 488-489, 506-508
Generated in workflow #1516

Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@svienot svienot merged commit 1660bf2 into main Dec 11, 2024
8 of 9 checks passed
@svienot svienot deleted the remove_key_alias branch December 11, 2024 09:27
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 24.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Key Alias" from account view
3 participants