Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduced NavMenuItem and used it in TopNavBar and MobileMenu. #1561

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below introduce new NavMenuItem view and use it in TopNavBar and MobileMenu views.

Related issue(s):

Fixes #1560

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

github-actions bot commented Dec 12, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.09% 24864 / 33559
🔵 Statements 74.09% 24864 / 33559
🔵 Functions 57.65% 945 / 1639
🔵 Branches 82.94% 4519 / 5448
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/page/NavMenuItem.vue 100% 100% 100% 100%
src/components/page/TopNavBar.vue 94.4% 53.84% 0% 94.4% 1, 154, 156, 169, 172-174
src/pages/MobileMenu.vue 100% 100% 100% 100%
src/utils/RouteManager.ts 77.93% 77.77% 62.5% 77.93% 136, 172-180, 203-212, 215-224, 242-243, 261-270, 277-280, 283-284, 305-314, 317-321, 324-328, 331-340, 343-347, 350-354, 372-381, 392-401, 412-421, 432-441, 448-451, 462-463, 502-503, 520-521, 532, 548-549, 551-552, 554-555, 557-558, 560-561, 563-564, 566-567, 569-570, 572-573, 575-576, 578-579, 581, 592, 614-615, 618-619
Generated in workflow #1524

@ericleponner ericleponner changed the title chore: introduced NavMenuItem and used in TopNavBar and MobileMenu. chore: introduced NavMenuItem and used it in TopNavBar and MobileMenu. Dec 12, 2024
Signed-off-by: Simon Viénot <[email protected]>
Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@svienot svienot merged commit 498b4f6 into main Dec 12, 2024
8 of 9 checks passed
@svienot svienot deleted the top_nav_bar branch December 12, 2024 12:49
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 24.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce CSS duplications in TopNavBar and MobileMenu views
3 participants