Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong hbar values assigned to Gas Limit, Gas Used, and Gas Consumed #1565

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Dec 13, 2024

Description:

With the changes below:

  • we use script setup syntax in ContractResult and do a tiny bit of refactoring
  • we always display the Gas Price in the Contract Result and get its value from /api/v1/network/fees at the corresponding timestamp.

[See detailed analysis of the issue in #1559]

Related issue(s):

Fixes #1559

Notes for reviewer:

Before:
394906549-1d32f539-08eb-4abe-8776-d63e5fa40f1f

After:
Screenshot 2024-12-13 at 18 15 41

… not provided by the contract result, we use the network fee from that point in time.

Signed-off-by: Simon Viénot <[email protected]>
Copy link

github-actions bot commented Dec 13, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.07% 24859 / 33560
🔵 Statements 74.07% 24859 / 33560
🔵 Functions 57.73% 948 / 1642
🔵 Branches 82.91% 4529 / 5462
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/contract/ContractResult.vue 100% 91.66% 100% 100%
src/pages/TransactionDetails.vue 98.99% 94.44% 50% 98.99% 1, 387, 457-458
src/schemas/MirrorNodeSchemas.ts 88.06% 70% 75% 88.06% 324-325, 749-751, 767, 887-891, 927, 930, 946-947, 950-951, 953-956
src/schemas/MirrorNodeUtils.ts 62.47% 72.64% 73.68% 62.47% 57-58, 64-65, 73-74, 81-82, 99-100, 114-116, 123-124, 134-137, 147-150, 155-156, 200-209, 211-212, 218-219, 248-249, 260-264, 287-295, 304-312, 315-323, 375-376, 378-390, 392-393, 395-423, 440-441, 443-454, 456-457, 463-470, 478-485, 493-500, 504-517
src/utils/cache/NetworkFeesCache.ts 91.66% 50% 100% 91.66% 39
Generated in workflow #1528

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ericleponner ericleponner merged commit 06b9d2e into main Dec 13, 2024
8 of 9 checks passed
@ericleponner ericleponner deleted the 1559-wrong-gas-cost branch December 13, 2024 18:02
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 24.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong hbar values assigned to Gas Limit, Gas Used, and Gas Consumed
3 participants