Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed obsolete AliasValue view #1575

Merged
merged 2 commits into from
Dec 23, 2024
Merged

chore: removed obsolete AliasValue view #1575

merged 2 commits into from
Dec 23, 2024

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below remove AliasValue view which is no longer used.
They also fix a few spots reported by lint.

Checklist

  • [] Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.05% 24817 / 33513
🔵 Statements 74.05% 24817 / 33513
🔵 Functions 57.74% 947 / 1640
🔵 Branches 83.15% 4533 / 5451
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/allowances/AllowancesSection.vue 65.28% 93.75% 0% 65.28% 53, 156-158, 165-181, 183-184, 189-190, 254-261, 264-268, 272-279, 283-292, 296-303, 307-314, 317-319, 322-324, 326-331
src/components/token/TokenMetadataAnalyzer.ts 71.79% 81.25% 90.9% 71.79% 103-105, 107, 145-149, 157-171, 231-232, 241, 249-250, 259-266, 280-286, 293-306, 308-309, 320-321, 323-326
src/utils/wallet/client/WalletClient_Ethereum.ts 24.08% 100% 0% 24.08% 53-57, 59-79, 81-93, 95-102, 111-116, 119-124, 128-129, 136, 138-140, 142-144, 146-151, 153-161, 163-165, 167, 169-171, 173-174, 177-189, 192-202, 206-223, 226-231, 234-236, 239-246, 249-255, 258, 260-275, 279, 281-292, 294-295, 299-300, 302-317
Generated in workflow #1535

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@svienot svienot merged commit 5486e0b into main Dec 23, 2024
8 of 9 checks passed
@svienot svienot deleted the remove-alias-value branch December 23, 2024 11:31
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 24.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants