Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add warning banner + info tooltip related to the possible pending reward calculation inaccuracy #1616

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Feb 4, 2025

Description:

  • put temporary banner only on Staking page
  • add InfoTooltip on Pending Reward property

Notes for reviewer:

This will only be activated once .env VARIABLE is set in the deployment repository.

@svienot svienot requested a review from ericleponner as a code owner February 4, 2025 22:17
Copy link

github-actions bot commented Feb 4, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74% 25287 / 34169
🔵 Statements 74% 25287 / 34169
🔵 Functions 57.8% 970 / 1678
🔵 Branches 82.93% 4550 / 5486
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/pages/AccountDetails.vue 38.83% 78.89% 0% 38.83% 1, 27-34, 36-45, 47-48, 51-56, 58-81, 83-88, 90-102, 104-108, 111-114, 116-121, 124-125, 127-130, 132-133, 135-136, 139-144, 146, 148-150, 152-164, 166, 168-174, 176-180, 182-186, 188-191, 193, 195-198, 200, 202-205, 207-208, 210-211, 213-219, 221-222, 224-225, 227-232, 234-236, 238-242, 244-246, 248, 251-255, 257-261, 263, 265-268, 270, 272, 274, 276-278, 280-300, 302-308, 310-312, 314-322, 324-325, 418-424, 427-428, 430, 473-474, 479-480, 497-499
src/pages/Staking.vue 51.15% 100% 0% 51.15% 277, 279-282, 284, 286-296, 298, 303-305, 307-309, 311-321, 323-327, 329-332, 334, 336-345, 347-349, 355-357, 363, 365-371, 373-375, 377-383, 385-387, 389, 391, 393-404, 406-410, 412, 414-427, 429-432, 434, 436-437, 439-450, 452-453, 458-461, 466-470, 472-515
src/pages/Transactions.vue 100% 100% 50% 100%
Generated in workflow #1583

ericleponner
ericleponner previously approved these changes Feb 4, 2025
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@svienot svienot merged commit 2096c05 into main Feb 5, 2025
15 checks passed
@svienot svienot deleted the reward-banner branch February 5, 2025 11:36
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 24.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants