Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Add info-tooltips for Gas Used and Gas Consumed in ContractResult. #1636

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Feb 18, 2025

Description:

All is said in the title.

Note this is in no way a breaking change, but marked with fix! in order to trigger the switch to version numbers 25.x.y moving forward.

Related issue(s):

Fixes #1621

Notes for reviewer:
Screenshot 2025-02-18 at 15 56 29
Screenshot 2025-02-18 at 15 56 38

Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 73.98% 25171 / 34020
🔵 Statements 73.98% 25171 / 34020
🔵 Functions 57.6% 962 / 1670
🔵 Branches 82.99% 4529 / 5457
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/contract/ContractResult.vue 100% 91.66% 100% 100%
Generated in workflow #1600

@svienot svienot merged commit ee2c5db into main Feb 18, 2025
15 checks passed
@svienot svienot deleted the 001621-hints-for-gas-used-gas-consumed branch February 18, 2025 15:14
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 24.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

svienot added a commit that referenced this pull request Feb 18, 2025
ericleponner pushed a commit that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add help hints to gas used/gas consumed fields on contract executions
3 participants