Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: miscellaneous fixes #803

Merged
merged 4 commits into from
Dec 14, 2023
Merged

fix: miscellaneous fixes #803

merged 4 commits into from
Dec 14, 2023

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Dec 14, 2023

Description:

A couple unrelated miscellaneous fixes:

  • always show REFRESH PAUSED when tables are not in play mode
  • always sort transactions by Nonce in TransactionById view
  • display Nonce or Relationship column only when relevant in TransactionById view
  • get rid of code related to IPFS/swarm since we do not leverage these for now

Notes for reviewer:

Deployed to staging server

@svienot svienot requested a review from ericleponner December 14, 2023 09:47
@svienot svienot self-assigned this Dec 14, 2023
Copy link

github-actions bot commented Dec 14, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.52% 33454 / 38221
🔵 Statements 87.52% 33454 / 38221
🔵 Functions 66.77% 820 / 1228
🔵 Branches 83.34% 3679 / 4414
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/PlayPauseButton.vue 88.03% 100% 33.33% 88.03% 82, 88-100
src/components/contract/ContractByteCodeSection.vue 97.82% 90% 25% 97.82% 32-33, 153-154
src/components/transaction/TransactionByIdTable.vue 97.79% 81.81% 40% 97.79% 47-48, 119-120
src/utils/analyzer/ByteCodeAnalyzer.ts 96.77% 88.88% 100% 96.77% 48-49
src/utils/analyzer/ContractAnalyzer.ts 84.92% 84.31% 87.5% 84.92% 70-80, 100-101, 111, 125, 137-148, 189-193, 210-211, 224-225, 238-239
src/utils/cache/TransactionGroupCache.ts 88% 60% 100% 88% 39-44
Generated in workflow #597

@svienot svienot force-pushed the miscellaneous-fixes branch from 59c47e1 to 6a6d0fc Compare December 14, 2023 14:41
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

1 Security Hotspot

See analysis details on SonarCloud

@svienot svienot merged commit 06c8930 into main Dec 14, 2023
4 of 5 checks passed
@svienot svienot deleted the miscellaneous-fixes branch December 14, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants