Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: contract URL should accept both contract id and evm address (#432) #805

Merged
merged 3 commits into from
Dec 18, 2023
Merged

feat: contract URL should accept both contract id and evm address (#432) #805

merged 3 commits into from
Dec 18, 2023

Conversation

ericleponner
Copy link
Collaborator

@ericleponner ericleponner commented Dec 18, 2023 •
edited
Loading

Description:
Changes below add support for URL:
<HEDERA_EXPLORER_URL>/<NETWORK>/contract/<CONTRACT_ADDRESS>
The also include unit and e2e tests.

Related issue(s):

Fixes #432

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ericleponner ericleponner requested a review from svienot December 18, 2023 11:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2023 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.58% 33589 / 38350
🔵 Statements 87.58% 33589 / 38350
🔵 Functions 67.01% 827 / 1234
🔵 Branches 83.5% 3721 / 4456
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/pages/ContractDetails.vue 98.63% 92.4% 100% 98.63% 74-78
src/utils/PathParam.ts 74.45% 76.92% 75% 74.45% 73-74, 78-79, 95-96, 102-117, 124-136
src/utils/parser/ContractLocParser.ts 99.23% 97.22% 100% 99.23% 112
Generated in workflow #600

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)
59.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

svienot
svienot approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ericleponner ericleponner merged commit c90109b into main Dec 18, 2023
4 of 5 checks passed
@ericleponner ericleponner deleted the 00432_contract_with_evm_address branch December 18, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svienot svienot svienot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

contract path should accept both contract id and evm address
2 participants
@ericleponner @svienot