Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replaced Ref<> by ComputedRef<> in some declarations. #807

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

ericleponner
Copy link
Collaborator

Description:

Typing cosmetic : some declarations should be ComputedRef<> in place of Ref<>.

Related issue(s):

None

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ericleponner ericleponner requested a review from svienot December 18, 2023 14:58
Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.58% 33589 / 38350
🔵 Statements 87.58% 33589 / 38350
🔵 Functions 67.01% 827 / 1234
🔵 Branches 83.5% 3721 / 4456
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/pages/ContractDetails.vue 98.63% 92.4% 100% 98.63% 74-78
src/utils/analyzer/BalanceAnalyzer.ts 93.33% 88.88% 100% 93.33% 53-55, 87, 100-102
src/utils/parser/AccountLocParser.ts 97.76% 93.67% 100% 97.76% 77-78, 93-94, 205
src/utils/parser/BlockLocParser.ts 99.17% 96.77% 100% 99.17% 103
src/utils/parser/ContractLocParser.ts 99.23% 97.22% 100% 99.23% 112
src/utils/parser/TransactionLocParser.ts 98.13% 95.83% 100% 98.13% 96-97, 129
Generated in workflow #602

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@ericleponner ericleponner merged commit 760f901 into main Dec 18, 2023
4 of 5 checks passed
@ericleponner ericleponner deleted the computed_ref branch December 18, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants