Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: WalletDriver_Metamask class now extends WalletDriver_Ethereum. #816

Merged
merged 2 commits into from
Dec 22, 2023
Merged

chore: WalletDriver_Metamask class now extends WalletDriver_Ethereum. #816

merged 2 commits into from
Dec 22, 2023

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below extract generic part of WalletDriver_Metamask in WalletDriver_Ethereum.
WalletDriver class hierarchy becomes:

WalletDriver
    WalletDriver_Hedera
        WalletDriver_Blade
        WalletDriver_Hashpack
    WalletDriver_Ethereum
        WalletDriver_Metamask

This should make Brave Wallet support easier (by simply adding WalletDriver_Brave).

Related issue(s):

None

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ericleponner ericleponner requested a review from svienot December 22, 2023 11:40
@ericleponner ericleponner marked this pull request as draft December 22, 2023 11:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 22, 2023 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 88.23% 32697 / 37057
🔵 Statements 88.23% 32697 / 37057
🔵 Functions 66.47% 789 / 1187
🔵 Branches 84.38% 3648 / 4323
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/utils/wallet/WalletDriver_Ethereum.ts 34.95% 100% 8.33% 34.95% 43-44, 47-48, 55-83, 86-88, 91-113, 116-138, 141-142, 149-154, 162-182, 185-197, 201-223
src/utils/wallet/WalletDriver_Metamask.ts 58.91% 100% 22.22% 58.91% 54-77, 84-90, 93-94, 97-100, 103-106, 115-126
Generated in workflow #608

@ericleponner
WalletDriver_Metamask now keeps MetaMaskInpageProvider instance and u…
32b5fb1 
…ses it to register to "chainChanged" events.

Signed-off-by: Eric Le Ponner <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@ericleponner ericleponner marked this pull request as ready for review December 22, 2023 15:08
@ericleponner ericleponner merged commit ee7b0be into main Dec 22, 2023
4 of 5 checks passed
@ericleponner ericleponner deleted the ethereum_wallet branch December 22, 2023 16:30
svienot added a commit that referenced this pull request Jan 8, 2024
@svienot
Revert "chore: WalletDriver_Metamask class now extends WalletDriver_E…
ee09bc6 
…thereum. (#816)"

This reverts commit ee7b0be.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svienot svienot svienot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericleponner @svienot