Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #822 collapsible sections #824

Merged
merged 8 commits into from
Jan 3, 2024
Merged

feat: #822 collapsible sections #824

merged 8 commits into from
Jan 3, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Dec 28, 2023

Description:

  • Make sections collapsible per spec. This is done for all pages but main pages which contain a single table (and the Dashboard page)
  • Remove navigation links from Staking page

Related issue(s):

Fixes #822

Notes for reviewer:

  • Deployed on staging server
  • Sample screenshot: Screenshot 2023-12-28 at 11 46 55

@svienot
Add arrow-up.svg and arrow-down.svg assets for upcoming use in collap…
224b74b 
…sible sections.

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Initial support for collapsible DashboardCard.
6fe00a1 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Make all sections collapsible except for pages containing a single ta…
869cf5b 
…ble.

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Remove 'show my account' and 'approve allowance...' links (now uneede…
0539e28 
…d) from the My Staking section.

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Fix layout of up/down arrow in collapsible section.
75346bc 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Introduce subtitle slot in DashboardCard and use it in AccountDetails…
36962e3 
… and ContractDetails.

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Adjust unit tests.
00eccf7 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Fix typo in staking tooltip and remove debug trace.
96923d8 
Signed-off-by: Simon Viénot <[email protected]>
@svienot svienot requested a review from ericleponner December 28, 2023 10:56
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 88.38% 33400 / 37789
🔵 Statements 88.38% 33400 / 37789
🔵 Functions 66.5% 800 / 1203
🔵 Branches 84.43% 3711 / 4395
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/AppStorage.ts 76.02% 68.18% 52.63% 76.02% 51-52, 55-56, 70-71, 98-100, 103-105, 118-119, 133-134, 145-146, 156-157, 159-160, 169-178, 181-195
src/components/DashboardCard.vue 94.28% 72.72% 25% 94.28% 107-114
src/components/allowances/ApproveAllowanceSection.vue 81.44% 78.94% 11.11% 81.44% 110-111, 114-116, 120-122, 149-156, 159-163, 166-170, 173-177, 180-189
src/components/contract/ContractByteCodeSection.vue 98.13% 91.66% 20% 98.13% 32-33, 178-179
src/components/contract/ContractResult.vue 100% 92.3% 100% 100%
src/components/contract/ContractResultLogs.vue 98.66% 94.11% 50% 98.66% 108-109
src/components/contract/ContractResultStates.vue 95.92% 83.33% 71.42% 95.92% 204-206, 215, 228-234
src/components/contract/ContractResultTrace.vue 96.09% 75% 16.66% 96.09% 92, 95-96, 98-99
src/components/contracts/ContractResultsSection.vue 100% 80% 100% 100%
src/components/staking/RewardsCalculator.vue 98.46% 93.75% 100% 98.46% 158-160
src/components/token/TokenCustomFees.vue 100% 100% 100% 100%
src/components/topic/TopicMessage.vue 100% 100% 100% 100%
src/pages/AccountDetails.vue 95.8% 84.21% 100% 95.8% 48-52, 109-113, 390-391, 404-405, 427-430, 460-461, 474-475
src/pages/BlockDetails.vue 96.98% 96.87% 20% 96.98% 175-177, 179-181
src/pages/ContractDetails.vue 98.64% 92.5% 100% 98.64% 76-80
src/pages/Nodes.vue 100% 81.48% 100% 100%
src/pages/Staking.vue 84.39% 86.81% 61.9% 84.39% 124-129, 139-167, 289-290, 296-319, 345-347, 391-392, 403-404, 435-450, 470-471
src/pages/TokenDetails.vue 98.74% 92.17% 66.66% 98.74% 60, 391, 404-405, 458-459
src/pages/TransactionDetails.vue 99.14% 94.01% 100% 99.14% 208, 350, 420-421
Generated in workflow #616

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

ericleponner
ericleponner approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ericleponner ericleponner merged commit 6761e85 into main Jan 3, 2024
4 of 5 checks passed
@ericleponner ericleponner deleted the 00822-collapsible-sections branch January 3, 2024 11:25
svienot added a commit that referenced this pull request Jan 8, 2024
@svienot
Revert "feat: #822 collapsible sections (#824)"
b89b311 
This reverts commit 6761e85.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collapsible sections in details views.
2 participants
@svienot @ericleponner