Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

00747 associate dissociate tokens #825

Closed
wants to merge 3 commits into from

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Dec 28, 2023

Description:

  • MetaMaskImport is replaced by AssociateAction which handles the Associate/Dissociate button displayed on the TokenDetails page when a wallet is connected (becomes Import/Dissociate if MetaMask is connected)
  • Remove the feature flag for MetaMask support. This is no longer needed.

Related issue(s):

Fixes #747

Notes for reviewer:

@svienot svienot marked this pull request as draft December 28, 2023 23:42
@svienot svienot self-assigned this Dec 28, 2023
@svienot svienot requested a review from ericleponner December 28, 2023 23:43
Copy link

github-actions bot commented Dec 28, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 88.27% 33405 / 37844
🔵 Statements 88.27% 33405 / 37844
🔵 Functions 66.5% 800 / 1203
🔵 Branches 84.51% 3710 / 4390
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/token/AssociateAction.vue 42.78% 100% 0% 42.78% 72-178
src/pages/TokenDetails.vue 98.95% 95.49% 66.66% 98.95% 393, 406-407, 460-461
src/utils/wallet/WalletManager.ts 64.12% 72.22% 53.33% 64.12% 93-98, 104-109, 116-120, 129-135, 142-143, 145-146, 150-159, 162-171, 174-183, 186-191, 194-199, 202-211
Generated in workflow #619

ericleponner
ericleponner previously approved these changes Jan 3, 2024
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@svienot svienot closed this Jan 10, 2024
@svienot svienot deleted the 00747-associate-dissociate-tokens branch January 10, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users want to associate tokens to their account
2 participants