Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tune padding and background in ByteCodeValue and DisassembledCodeValue. #831

Merged
merged 1 commit into from
Jan 5, 2024
Merged

fix: tune padding and background in ByteCodeValue and DisassembledCodeValue. #831

merged 1 commit into from
Jan 5, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Jan 5, 2024

Description:

Minor tweaks for the code boxes.

Notes for reviewer:

Screenshot 2024-01-05 at 19 38 26

@svienot svienot requested a review from ericleponner January 5, 2024 18:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 88.37% 33381 / 37770
🔵 Statements 88.37% 33381 / 37770
🔵 Functions 66.5% 800 / 1203
🔵 Branches 84.43% 3711 / 4395
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/contract/ContractByteCodeSection.vue 98.13% 91.66% 20% 98.13% 32-33, 178-179
src/components/values/ByteCodeValue.vue 100% 83.33% 100% 100%
src/components/values/DisassembledCodeValue.vue 96.9% 57.14% 100% 96.9% 72-73, 80
Generated in workflow #623

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

1 Security Hotspot

See analysis details on SonarCloud

ericleponner
ericleponner approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svienot svienot merged commit b34ec5d into main Jan 5, 2024
4 of 5 checks passed
@svienot svienot deleted the fix-bytecode-section branch January 5, 2024 19:32
svienot added a commit that referenced this pull request Jan 8, 2024
@svienot
Revert "fix: tune padding and background in ByteCodeValue and Disasse…
0caee69 
…mbledCodeValue. (#831)"

This reverts commit b34ec5d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svienot @ericleponner