Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error decoding not working as expected on verified contract #833

Merged
merged 2 commits into from
Jan 5, 2024
Merged

fix: error decoding not working as expected on verified contract #833

merged 2 commits into from
Jan 5, 2024

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below fix #829: FunctionError vue now displays error arguments.
They also include some new unit test cases in FunctionCallAnalyzer.spec.ts.

Related issue(s):

Fixes #829

Notes for reviewer:
See #829 for testing data.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 88.4% 33414 / 37798
🔵 Statements 88.4% 33414 / 37798
🔵 Functions 66.5% 800 / 1203
🔵 Branches 84.55% 3734 / 4416
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/values/FunctionError.vue 72.59% 75% 100% 72.59% 28-62, 70-71
src/utils/analyzer/FunctionCallAnalyzer.ts 98.43% 84.5% 100% 98.43% 172, 233-235
Generated in workflow #625

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)
87.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ericleponner ericleponner requested a review from svienot January 5, 2024 19:14
svienot
svienot approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@svienot svienot merged commit e49b4c5 into main Jan 5, 2024
4 of 5 checks passed
@svienot svienot deleted the 00829_error_decoding branch January 5, 2024 19:32
svienot added a commit that referenced this pull request Jan 8, 2024
@svienot
Revert "fix: error decoding not working as expected on verified contr…
a9c1a33 
…act (#833)"

This reverts commit e49b4c5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svienot svienot svienot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error decoding not working as expected on verified contract
2 participants
@ericleponner @svienot