Add primary datasource for web3 #10197
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Nelson <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10197 +/- ##
============================================
- Coverage 92.38% 92.05% -0.33%
- Complexity 5578 7929 +2351
============================================
Files 730 969 +239
Lines 24705 33195 +8490
Branches 3225 4179 +954
============================================
+ Hits 22824 30559 +7735
- Misses 1122 1656 +534
- Partials 759 980 +221 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jesse Nelson <[email protected]>
|
jnels124
commented
Jan 21, 2025
| @Value("${hedera.mirror.web3.db.host}") String defaultHost) { | ||
| var url = properties | ||
| .determineUrl() | ||
| .replaceAll("jdbc:postgresql://" + defaultHost, "jdbc:postgresql://" + primaryHost); |
There was a problem hiding this comment.
replace is fine here . will fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist