Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP-1056 Add token blockitem to recorditem transformers #10354

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

edwin-greene
Copy link
Contributor

@edwin-greene edwin-greene commented Feb 10, 2025

Description:
Adds the following transformers:

  • tokenAirdrop
  • tokenBurn
  • tokenCreate
  • tokenMint
  • tokenWipe

Update existing transformer tests for default transforms.

Related issue(s):

Fixes #10168

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
@edwin-greene edwin-greene added enhancement Type: New feature importer Area: Importer labels Feb 10, 2025
@edwin-greene edwin-greene added this to the 0.124.0 milestone Feb 10, 2025
@edwin-greene edwin-greene self-assigned this Feb 10, 2025
@edwin-greene edwin-greene linked an issue Feb 10, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 81.53846% with 24 lines in your changes missing coverage. Please review.

Project coverage is 92.14%. Comparing base (61a985e) to head (8cf8768).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...er/block/transformer/AbstractTokenTransformer.java 47.05% 3 Missing and 6 partials ⚠️
...ader/block/transformer/TokenCreateTransformer.java 46.66% 3 Missing and 5 partials ⚠️
...der/block/transformer/TokenAirdropTransformer.java 90.41% 0 Missing and 7 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10354      +/-   ##
============================================
- Coverage     92.18%   92.14%   -0.05%     
- Complexity     8101     8150      +49     
============================================
  Files           989      995       +6     
  Lines         33729    33884     +155     
  Branches       4267     4298      +31     
============================================
+ Hits          31093    31222     +129     
- Misses         1619     1626       +7     
- Partials       1017     1036      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Edwin Greene <[email protected]>
@edwin-greene edwin-greene marked this pull request as ready for review February 10, 2025 21:38
@edwin-greene edwin-greene requested a review from a team as a code owner February 10, 2025 21:38
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
@edwin-greene
Copy link
Contributor Author

edwin-greene commented Feb 13, 2025

Will fix Gradle build; the failing importer tests pass locally in IntelliJ and on the command line, investigating.

This should now be fixed.

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature importer Area: Importer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIP-1056 Token BlockItem to RecordItem transformers
2 participants