-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clear words in RestoreKey #1515
fix: clear words in RestoreKey #1515
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1515 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 159 159
Lines 5950 5950
Branches 1084 1090 +6
=======================================
Hits 5895 5895
+ Misses 55 52 -3
- Partials 0 3 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix is not applied everywhere.
To apply it, change the setter function the userStore to this:
const setRecoveryPhrase = async (words: string[] | null) => {
if (words === null) {
recoveryPhrase.value = { words: [], hash: '' } as unknown as RecoveryPhrase;
await nextTick();
recoveryPhrase.value = null;
} else {
recoveryPhrase.value = await ush.createRecoveryPhrase(words);
}
};
and find everywhere in the app the direct assignments of the recovery phrase and replace them with the setter function
481408e
to
8ef0cf1
Compare
e668453
to
62f9a08
Compare
62f9a08
to
475f282
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested.
@yiliev0 We may need to adjust the tests to catch for the issue I described in my review. |
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
aaa5d8f
to
74c40e1
Compare
Signed-off-by: Yordan Iliev <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Yordan Iliev <[email protected]>
Signed-off-by: Yordan Iliev <[email protected]>
Description:
Simple fix of clear words handler in RestoreKey. (watcher in child component wasn't detecting the changes on clicking of the 'clear' button).
Related issue(s):
#1375