Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1342 threshold nicknames #1544

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

1342 threshold nicknames #1544

wants to merge 2 commits into from

Conversation

Sheng-Long
Copy link
Contributor

Description:
fixes threshold nickname bugs

Related issue(s):

Fixes #1342, #1542

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Sheng-Long Sheng-Long force-pushed the 1342-threshold-nicknames branch 2 times, most recently from 91e9824 to 629b960 Compare February 12, 2025 16:27
@jsync-swirlds jsync-swirlds requested review from jbair06 and removed request for jsync-swirlds February 12, 2025 16:27
@Sheng-Long Sheng-Long force-pushed the 1342-threshold-nicknames branch from 629b960 to 0e7724e Compare February 12, 2025 16:36
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.07%. Comparing base (d503ab2) to head (4fa8367).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1544   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files         159      159           
  Lines        5954     5957    +3     
  Branches     1094     1092    -2     
=======================================
+ Hits         5899     5902    +3     
  Misses         52       52           
  Partials        3        3           
Files with missing lines Coverage Δ
...ont-end/src/main/services/localUser/complexKeys.ts 100.00% <100.00%> (ø)

Impacted file tree graph

@Sheng-Long Sheng-Long force-pushed the 1342-threshold-nicknames branch 2 times, most recently from 21be27f to 35e9a56 Compare February 12, 2025 17:11
yiliev0

This comment was marked as resolved.

yiliev0

This comment was marked as resolved.

@Sheng-Long Sheng-Long force-pushed the 1342-threshold-nicknames branch from 35e9a56 to 3f1d516 Compare February 13, 2025 13:00
@Sheng-Long
Copy link
Contributor Author

Fixed those, bad rebase

@yiliev0
Copy link
Contributor

yiliev0 commented Feb 13, 2025

Issue#1
When saving a complex key structure and returning to it, the threshold names are not persisted.
Steps to reproduce:

  1. Navigate to create account tx
  2. Click on +Create new button for complex key structure
  3. Create a threshold with two inner thresholds inside
  4. Set nicknames to the thresholds
  5. Click on "Save Complex Key" button and set name to this structure
  6. Navigate back to the transaction or create a new one, instead, click on Add existing complex structure and select the structure from step 5.
  7. Observe the missing nicknames

Issue#2
When creating a transaction with thresholds that have nicknames, the nicknames are not saved and displayed in the transaction details

  1. Navigate to create account tx
  2. Click on +Create new button
  3. Create a threshold with two inner thresholds inside
  4. Set nicknames to thresholds
  5. Sign & Execute the transaction
  6. Once navigated to the Transaction Details, under the account create info section, click on "See Details"
  7. Observe the default "Threshold" nicknames

@Sheng-Long Sheng-Long force-pushed the 1342-threshold-nicknames branch from 3f1d516 to 7b71e9e Compare February 14, 2025 13:24
@Sheng-Long Sheng-Long force-pushed the 1342-threshold-nicknames branch from 7b71e9e to 4fa8367 Compare February 14, 2025 13:26
@Sheng-Long
Copy link
Contributor Author

New changes should have fixed the issues above

@Sheng-Long Sheng-Long requested a review from yiliev0 February 14, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create nicknames for thresholds
2 participants