feat: unsaved group modal, fix: route leave logic #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
icoxxx
requested review from
SvetBorislavov,
yiliev0 and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1552 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 159 159
Lines 5954 5954
Branches 1094 1092 -2
=======================================
Hits 5899 5899
Misses 52 52
Partials 3 3 |
jsync-swirlds
requested review from
jbair06
and removed request for
jsync-swirlds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR improves 'on route leave' logic, adds a new modal to warn users when leaving a 'create transaction' page during the process of group creating/editing, and includes a minor refactor of the components used in the flow.
Related issue(s):
none
Fixes #
BaseTransactionModal, BaseTransaction, BaseGroupHandler