-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution for multiple wallet connect instances #412
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Kantor <[email protected]>
Signed-off-by: Michael Kantor <[email protected]>
Signed-off-by: Michael Kantor <[email protected]>
Signed-off-by: Michael Kantor <[email protected]>
Signed-off-by: Michael Kantor <[email protected]>
Signed-off-by: Deligrim <[email protected]>
CON-558 Update docs to include react-native edge cases
Signed-off-by: Tyler McDonald <[email protected]>
Signed-off-by: Tyler McDonald <[email protected]>
Signed-off-by: Tyler McDonald <[email protected]>
Signed-off-by: Deligrim <[email protected]>
CON-603 Multiple session issue with wallet connect
@teacoat does this seem like a viable solution for dApps for having multiple browser tabs open? |
That's a fantastic improvement! However, this doesn't allow the user to interact with multiple tabs, it only enables interaction with the most recent tab they connected to. I believe it remains essential to address the issue of using multiple tabs simultaneously. |
Hmmm, having to close all other tabs would be similar to the current experience, I am also worried about maintaining any code that touches the relay directly in this way and would suggest end to end tests to keep track of this in case the base functionality changes again |
Signed-off-by: Deligrim <[email protected]>
Signed-off-by: Deligrim <[email protected]>
Signed-off-by: Deligrim <[email protected]>
Signed-off-by: Deligrim <[email protected]>
Signed-off-by: Deligrim <[email protected]>
Signed-off-by: Deligrim <[email protected]>
Signed-off-by: Deligrim <[email protected]>
…tory Signed-off-by: Deligrim <[email protected]>
CON-513 implement getAccountKeyAsync
…nsactions Signed-off-by: Tyler McDonald <[email protected]>
HG-327 Explore submitting basic transactions on Hedera
…ionality HG-394 Migrate multi node functionality to main wallet connect repository
I think we should leave to this to walletconnect to resolve |
Description:
This offers a solution in the cases where there are multiple browser tabs open.
In testing by @deligrim :
Related issue(s):
Fixes #387
Notes for reviewer:
Checklist