Add information regarding Ed25519 & ECDSA Keys to docs (fixed verification) #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsbrandondev
added
the
New Feature
itsbrandondev
requested review from
web3-nomad,
kantorcodes,
tmctl and
hgraphql
Coverage report
Test suite run success153 tests passing in 11 suites. Report generated by 🧪jest coverage report action from 78829d2 |
|
i will be applying new updates now that the PR is fixed |
tmctl
previously approved these changes
Feb 4, 2025
tmctl
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new page to the WalletConnect documentation that explians the differences of Ed25519 & ECDSA keys, important for ETH developers who need full EVM compatibility.
It also modifies one page to move it down the sidebar.
This PR is informational and only adds to the documentation, it does not impact the library.
Note for reviewers: this is a new version of PR 419 (my github gpg verification was not set up)