Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flags to support aws as storage destination #1372

Merged
merged 33 commits into from
Feb 12, 2025

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Feb 12, 2025

Description

This pull request changes the following:

  • Add new set of flags to support aws storage bucket
  • network.ts use gcs??? and aws??? as destination bucket parameters
  • mirror-node.ts use storage??? as download bucket parameters
  • update test script to se aws set of of parameter to store to GCS storage

Related Issues

Storage test result

https://github.com/hashgraph/solo/actions/runs/13291631566

Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	src/commands/network.ts
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Copy link
Contributor

Unit Test Results - Linux

  1 files  ±0   61 suites  ±0   1s ⏱️ -1s
237 tests ±0  237 ✅ ±0  0 💤 ±0  0 ❌ ±0 
246 runs  ±0  246 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 863379d. ± Comparison against base commit 8411ff3.

Copy link
Contributor

Unit Test Results - Windows

  1 files  ±0   61 suites  ±0   3s ⏱️ ±0s
237 tests ±0  237 ✅ ±0  0 💤 ±0  0 ❌ ±0 
246 runs  ±0  246 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 863379d. ± Comparison against base commit 8411ff3.

Copy link
Contributor

github-actions bot commented Feb 12, 2025

E2E Test Report

 17 files  126 suites   1h 28m 49s ⏱️
254 tests 254 ✅ 0 💤 0 ❌
265 runs  265 ✅ 0 💤 0 ❌

Results for commit 863379d.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Feb 12, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.18% (target: -1.00%) 83.46%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8411ff3) 23707 19815 83.58%
Head commit (863379d) 23853 (+146) 19981 (+166) 83.77% (+0.18%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1372) 254 212 83.46%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 81.88976% with 46 lines in your changes missing coverage. Please review.

Project coverage is 82.67%. Comparing base (369065e) to head (863379d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/network.ts 58.94% 39 Missing ⚠️
src/commands/mirror_node.ts 12.50% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1372      +/-   ##
==========================================
+ Coverage   82.47%   82.67%   +0.20%     
==========================================
  Files         130      130              
  Lines       23642    23853     +211     
  Branches     2366     1475     -891     
==========================================
+ Hits        19498    19720     +222     
- Misses       3904     4116     +212     
+ Partials      240       17     -223     
Files with missing lines Coverage Δ
src/commands/flags.ts 77.05% <100.00%> (+1.43%) ⬆️
src/core/constants.ts 97.28% <100.00%> (-0.02%) ⬇️
src/commands/mirror_node.ts 69.71% <12.50%> (-0.04%) ⬇️
src/commands/network.ts 68.08% <58.94%> (+1.88%) ⬆️

... and 54 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon merged commit 5ca0e47 into main Feb 12, 2025
44 of 45 checks passed
@jeromy-cannon jeromy-cannon deleted the 01102-D-s3-bucket branch February 12, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants