chore: account init to update node admin key #1373

JeffreyDallas · 2025-02-12T15:36:46Z

Description

This pull request changes the following:

account init to update node admin key

Related Issues

Closes Production Readiness: Update account init/rekey logic to also update the Node admin keys #935

Signed-off-by: Jeffrey Tang <[email protected]>

Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/account.ts

github-actions · 2025-02-12T15:39:06Z

Unit Test Results - Linux

1 files ±0 62 suites ±0 2s ⏱️ -1s
241 tests ±0 241 ✅ ±0 0 💤 ±0 0 ❌ ±0
250 runs ±0 250 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 457f2a9. ± Comparison against base commit 370f57b.

♻️ This comment has been updated with latest results.

github-actions · 2025-02-12T15:40:28Z

Unit Test Results - Windows

1 files ±0 62 suites ±0 2s ⏱️ -1s
241 tests ±0 241 ✅ ±0 0 💤 ±0 0 ❌ ±0
250 runs ±0 250 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 457f2a9. ± Comparison against base commit 370f57b.

♻️ This comment has been updated with latest results.

github-actions · 2025-02-12T16:07:43Z

E2E Test Report

17 files 126 suites 1h 28m 27s ⏱️
255 tests 255 ✅ 0 💤 0 ❌
266 runs 266 ✅ 0 💤 0 ❌

Results for commit 1a48a93.

♻️ This comment has been updated with latest results.

codacy-production · 2025-02-12T16:08:06Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.01% (target: -1.00%)	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`8411ff3`)	23707	19815	83.58%
Head commit (`1a48a93`)	23721 (+14)	19829 (+14)	83.59% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1373)	15	15	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

codecov · 2025-02-12T16:09:24Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.52%. Comparing base (369065e) to head (1a48a93).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1373      +/-   ##
==========================================
+ Coverage   82.47%   82.52%   +0.04%     
==========================================
  Files         130      130              
  Lines       23642    23721      +79     
  Branches     2366     1493     -873     
==========================================
+ Hits        19498    19575      +77     
- Misses       3904     4133     +229     
+ Partials      240       13     -227

Files with missing lines	Coverage Δ
src/commands/account.ts	`76.08% <100.00%> (+0.51%)`	⬆️

... and 56 files with indirect coverage changes

jeromy-cannon · 2025-02-12T21:54:48Z

src/commands/account.ts

+                    const newPrivateKey = PrivateKey.generateED25519();
+                    const genesisAccountId = AccountId.fromString(constants.FREEZE_ADMIN_ACCOUNT);
+                    // update genesis account key
+                    await self.accountManager.updateAccountKeys(


this is not what was meant. We need to update the Node Admin Keys. I believe the only way to do this is via the NodeUpdateTransaction:

solo/src/commands/node/tasks.ts

Line 1438 in 929fdaa

self.logger.info(`config.tlsPublicKey: ${config.tlsPublicKey}`);

jeromy-cannon

Need to use NodeUpdateTransaction to update each of the node's admin keys.

…node-adminkey

Signed-off-by: Jeffrey Tang <[email protected]>

…node-adminkey Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/account.ts # src/commands/node/tasks.ts

Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas added 2 commits February 5, 2025 10:25

update admin key

4a24531

Signed-off-by: Jeffrey Tang <[email protected]>

Merge branch 'main' into 00935-D-node-adminkey

1a48a93

Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/account.ts

JeffreyDallas requested review from leninmehedy and a team as code owners February 12, 2025 15:36

JeffreyDallas marked this pull request as draft February 12, 2025 15:36

JeffreyDallas marked this pull request as ready for review February 12, 2025 17:48

JeffreyDallas requested a review from jeromy-cannon February 12, 2025 17:48

jeromy-cannon assigned JeffreyDallas Feb 12, 2025

jeromy-cannon reviewed Feb 12, 2025

View reviewed changes

jeromy-cannon requested changes Feb 12, 2025

View reviewed changes

jeromy-cannon added the PR: Unresolved Comments A pull request where there are comments and they need to be resolved. label Feb 12, 2025

JeffreyDallas added 2 commits February 13, 2025 10:18

Merge commit '4618a4319a2fda48e66222381adf6fe9acea9afd' into 00935-D-…

d317c72

…node-adminkey

save

a5fcd64

Signed-off-by: Jeffrey Tang <[email protected]>

jeromy-cannon added the PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. label Feb 14, 2025

JeffreyDallas added 5 commits February 14, 2025 17:06

save node admin key to k8s secret

51bc7ea

Signed-off-by: Jeffrey Tang <[email protected]>

save

d500e18

Signed-off-by: Jeffrey Tang <[email protected]>

Merge commit '370f57b9425c4d98ad1bf56b114c3e5a4904c441' into 00935-D-…

a0a934a

…node-adminkey Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/account.ts # src/commands/node/tasks.ts

save

4837ab0

Signed-off-by: Jeffrey Tang <[email protected]>

save

457f2a9

Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas added PR: Needs Approval A pull request that needs reviews and approvals. and removed PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. labels Feb 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: account init to update node admin key #1373

chore: account init to update node admin key #1373

JeffreyDallas commented Feb 12, 2025

github-actions bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

codacy-production bot commented Feb 12, 2025 •

edited

Loading

codecov bot commented Feb 12, 2025 •

edited

Loading

jeromy-cannon Feb 12, 2025

JeffreyDallas Feb 15, 2025

jeromy-cannon left a comment

chore: account init to update node admin key #1373

Are you sure you want to change the base?

chore: account init to update node admin key #1373

Conversation

JeffreyDallas commented Feb 12, 2025

Description

Related Issues

github-actions bot commented Feb 12, 2025 • edited Loading

Unit Test Results - Linux

github-actions bot commented Feb 12, 2025 • edited Loading

Unit Test Results - Windows

github-actions bot commented Feb 12, 2025 • edited Loading

E2E Test Report

codacy-production bot commented Feb 12, 2025 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

codecov bot commented Feb 12, 2025 • edited Loading

Codecov Report

jeromy-cannon Feb 12, 2025

Choose a reason for hiding this comment

JeffreyDallas Feb 15, 2025

Choose a reason for hiding this comment

jeromy-cannon left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

codacy-production bot commented Feb 12, 2025 •

edited

Loading

codecov bot commented Feb 12, 2025 •

edited

Loading