Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi-cluster): updated 'solo account init' to upload secrets to all clusters #1399

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

instamenta
Copy link
Contributor

Description

  • Changed the AccountManager.updateAccountKeys to create the secrets inside all available clusters.

Related Issues

@instamenta instamenta self-assigned this Feb 15, 2025
@instamenta instamenta requested review from leninmehedy and a team as code owners February 15, 2025 14:50
@instamenta instamenta linked an issue Feb 15, 2025 that may be closed by this pull request
@instamenta instamenta marked this pull request as draft February 15, 2025 14:50
@instamenta instamenta marked this pull request as ready for review February 15, 2025 14:51
Copy link
Contributor

github-actions bot commented Feb 15, 2025

Unit Test Results - Linux

  1 files  ±0   62 suites  ±0   3s ⏱️ -1s
241 tests ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 
250 runs  ±0  250 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 93a3f8d. ± Comparison against base commit f3f7958.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 15, 2025

Unit Test Results - Windows

  1 files  ±0   62 suites  ±0   4s ⏱️ +2s
241 tests ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 
250 runs  ±0  250 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 93a3f8d. ± Comparison against base commit f3f7958.

♻️ This comment has been updated with latest results.

Co-authored-by: Nathan Klick <[email protected]>
Signed-off-by: Jan Milenkov <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 15, 2025

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 36m 1s ⏱️ -24s
272 tests ±0  272 ✅ ±0  0 💤 ±0  0 ❌ ±0 
287 runs  ±0  287 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 93a3f8d. ± Comparison against base commit f3f7958.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Feb 15, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 79.63%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f3f7958) 25284 21432 84.77%
Head commit (93a3f8d) 25294 (+10) 21448 (+16) 84.79% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1399) 54 43 79.63%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 79.62963% with 11 lines in your changes missing coverage. Please review.

Project coverage is 83.67%. Comparing base (f3f7958) to head (93a3f8d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/core/account_manager.ts 69.69% 10 Missing ⚠️
src/commands/account.ts 95.23% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1399      +/-   ##
==========================================
+ Coverage   83.64%   83.67%   +0.02%     
==========================================
  Files         132      132              
  Lines       25284    25294      +10     
  Branches     1614     2479     +865     
==========================================
+ Hits        21150    21165      +15     
+ Misses       4117     3956     -161     
- Partials       17      173     +156     
Files with missing lines Coverage Δ
src/commands/account.ts 77.89% <95.23%> (+0.21%) ⬆️
src/core/account_manager.ts 85.93% <69.69%> (+0.53%) ⬆️

... and 46 files with indirect coverage changes

Impacted file tree graph

nathanklick
nathanklick previously approved these changes Feb 15, 2025
jeromy-cannon
jeromy-cannon previously approved these changes Feb 15, 2025
@jeromy-cannon jeromy-cannon added the PR: Ready to Merge A pull request that is ready to merge. label Feb 15, 2025
…init-to-upload-secrets-to-all-clusters

# Conflicts:
#	src/commands/account.ts
@instamenta instamenta dismissed stale reviews from jeromy-cannon and nathanklick via 93a3f8d February 16, 2025 14:43
@instamenta instamenta added PR: Needs Approval A pull request that needs reviews and approvals. and removed PR: Ready to Merge A pull request that is ready to merge. labels Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs Approval A pull request that needs reviews and approvals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update account init to upload secrets to all clusters
3 participants