Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(security-scanner): add support for Red Hat UBI images and fix typo #21912

Merged
merged 3 commits into from
Nov 4, 2024
Merged

ci(security-scanner): add support for Red Hat UBI images and fix typo #21912

merged 3 commits into from
Nov 4, 2024

Conversation

dduzgun-security
Copy link
Collaborator

@dduzgun-security dduzgun-security commented Nov 4, 2024 •
edited by jira bot
Loading

Description

Adding support for RedHat UBI images scans to cover more type of container images and fixing a typo.

Ref: PSP-2287

Testing & Reproduction steps

https://github.com/hashicorp/security-scanner/pull/918

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@dduzgun-security dduzgun-security requested a review from a team as a code owner November 4, 2024 19:18
@dduzgun-security dduzgun-security added the pr/no-changelog PR does not need a corresponding .changelog entry label Nov 4, 2024
@dduzgun-security dduzgun-security self-assigned this Nov 4, 2024
@dduzgun-security dduzgun-security added backport/all Apply backports for all active releases per .release/versions.hcl type/ci Relating to continuous integration (CI) tooling for testing or releases labels Nov 4, 2024
picatz
picatz requested changes Nov 4, 2024
View reviewed changes
.release/security-scan.hcl Outdated Show resolved Hide resolved
.release/security-scan.hcl Outdated Show resolved Hide resolved
scan.hcl Outdated Show resolved Hide resolved
@dduzgun-security @picatz
clean-up comments
5610471 
Co-authored-by: Kent Gruber <[email protected]>
@dduzgun-security dduzgun-security merged commit 1dfc265 into main Nov 4, 2024
94 checks passed
@dduzgun-security dduzgun-security deleted the ci/security-scanner branch November 4, 2024 19:52
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.20 Changes are backported to 1.20 backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.19 Changes are backported to 1.19 ent labels Nov 4, 2024
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Nov 4, 2024
Merged
4 tasks
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @dduzgun-security! a backport is missing for this PR [21912] for versions [1.15,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahalsmiller sarahalsmiller sarahalsmiller approved these changes

@picatz picatz picatz approved these changes

Assignees

@dduzgun-security dduzgun-security

Labels
backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.19 Changes are backported to 1.19 ent backport/1.20 Changes are backported to 1.20 pr/no-changelog PR does not need a corresponding .changelog entry type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dduzgun-security @hc-github-team-consul-core @picatz @sarahalsmiller