Add linting step to CI #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maed223
force-pushed
the
add-linting-to-ci
branch
3 times, most recently
from
3211154 to
d14f342
Compare
…hicorp/go-version' package 'version'
Maed223
force-pushed
the
add-linting-to-ci
branch
from
8216529 to
856db90
Compare
Maed223
force-pushed
the
add-linting-to-ci
branch
from
856db90 to
f8795a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds linting to the CI checks, and fixes for the new linting errors that introduces.
Apologies in advance for the breadth of changes to fix the existing linting errors. Tried to group similar things by commit to make the reason for the changes more obvious for reviewers.
Testing plan
Updated certain tests in
host_test.goas I changed the format of errors being return to align with the stylecheck linter.External links
JIRA: https://hashicorp.atlassian.net/browse/TF-21753?atlOrigin=eyJpIjoiMjViMWU0YmY2YWE4NGZmMTkwMGFjZDk2ZGFhZjRmNjMiLCJwIjoiaiJ9