feat(network): add NCM connect/disconnect status #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Device can notify the host about network connection status by CDC NetworkConnection. In the current scheme, the host does not re-initiate the DHCP process even if WiFi is connected to a different router. We used it to solve the problem that WiFi devices would connect to different routers.
|
Out of curiosity: have you checked my NCM PR (#2227)? It should perform better and more bugfree than the original NCM device. |
|
Sorry for the delay, since #2227 is merged, could you make a rebase ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device can notify the host about network connection status by CDC NetworkConnection.
In the current scheme, the host does not re-initiate the DHCP process even if WiFi is connected to a different router. We used it to solve the problem that WiFi devices would connect to different routers.