Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow retrieving the port a device is connected to #2357

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

Yveaux
Copy link
Contributor

@Yveaux Yveaux commented Nov 29, 2023

Describe the PR
Sometimes it may be handy to know to which port a device is connected to, e.g. when dealing with identical devices.
This change allows the port number of a device to be retrieved.

Additional context
Supports root hub and external hub ports.

@Yveaux
Copy link
Contributor Author

Yveaux commented Dec 4, 2023

Anything I can do to fix this?

image

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tuh_get_port() is a confusing API name and its return in the PR is inconsistent as well. We can have an public API for hcd_devtree_get_info() with the name e.g tuh_devtree_get_info()

@Yveaux
Copy link
Contributor Author

Yveaux commented Feb 8, 2024

Something like this? I'm in doubt where everything should land...

@Yveaux Yveaux requested a review from hathach February 10, 2024 10:25
@Yveaux
Copy link
Contributor Author

Yveaux commented Apr 15, 2024

@hathach ping, is this what you were looking for?

@Yveaux
Copy link
Contributor Author

Yveaux commented Sep 14, 2024

@hathach how can we bring this further?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants