Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renesas ra8 support. #2601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add renesas ra8 support. #2601

wants to merge 1 commit into from

Conversation

Rbb666
Copy link
Contributor

@Rbb666 Rbb666 commented Apr 16, 2024

Describe the PR
Add renesas cortex-m85 ra8 support.

Additional context
If applicable, add any other context about the PR and/or screenshots here.

@@ -48,6 +48,7 @@ extern "C" {
/* Start of definition of packed structs (used by the CCRX toolchain) */
TU_ATTR_PACKED_BEGIN
TU_ATTR_BIT_FIELD_ORDER_BEGIN
#pragma pack(2)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that using the armclang compiler(ac6) without adding this code will cause it to not run properly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If pack is wrong it should be fixed in src/common/tusb_compiler.h

@@ -356,6 +356,7 @@
#elif TU_CHECK_MCU(OPT_MCU_RX63X, OPT_MCU_RX65X, OPT_MCU_RX72N, OPT_MCU_RAXXX)
#define TUP_USBIP_RUSB2
#define TUP_DCD_ENDPOINT_MAX 10
#define TUP_RHPORT_HIGHSPEED 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to put this statement inside conditional check as other MCUs don't support HS. For example #if defined(BSP_MCU_GROUP_RA8M1)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which board you are testing with, please also add the board to hw/bsp/ra to make sure it got built by ci.

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you still working on this PR? If so please follow above review to add bsp for the new board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants