Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tool version string #12

Closed
wants to merge 2 commits into from

Conversation

se-bi
Copy link
Contributor

@se-bi se-bi commented Jan 17, 2021

Hey,
as discussed in #4, the first part:
adding git to a base building images and get source code later by git clone to derive version strings.

Spoiler alert, due to missing workflow dependencies and change in the base images which is already used for the other changes, those two other builds (nextpnr, yosys) fail on the first run 🙈

@eine
Copy link
Collaborator

eine commented Jan 17, 2021

adding git to a base building images and get source code later by git clone to derive version strings.

The first commit (adding git) was cherry-picked. Thanks!

The other changes (running tool --version), need to be added in hdl/smoke-tests. Then, bump the submodule here. Let's keep this PR open for handling that, if you want. Or close this and open a new one. As you wish.

Spoiler alert, due to missing workflow dependencies and change in the base images which is already used for the other changes, those two other builds (nextpnr, yosys) fail on the first run 🙈

Yes, this is expected for now. Workflows have dispatch keys, and there is a trigger script in subdir .github. But sequencing the workflows was not implemented yet. Currently, all of them are executed at the same time. Hence, there are some races and cross-dependency issue. I told this for you to be aware only. You don't need to worry about it (just test it locally). We'll handle it by rerunning workflows manually for now.

@se-bi
Copy link
Contributor Author

se-bi commented Jan 17, 2021

The first commit (adding git) was cherry-picked. Thanks!
Also Thanks!

The other changes (running tool --version), need to be added in hdl/smoke-tests.
Indeed.

@se-bi se-bi closed this Jan 17, 2021
@eine eine added enhancement New feature or request $R/build Related to `$R/build` images and their dependencies labels Jan 17, 2021
@se-bi se-bi deleted the feature/tool-version-string branch January 19, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request $R/build Related to `$R/build` images and their dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants