-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nextpnr: restructure a bit and add pkg images #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, address the comment below and rebase on top of main
. This seems to contain some modifcations from the other PR (already merged).
815b47d
to
a9dbd8c
Compare
LGTM. Do you want to handle doc modifications in this same PR, or will be finish the technical modifications first and we will later document all the changes at once? |
a9dbd8c
to
d450fe3
Compare
valid point! Though first reaction was kind of 🙈 After a quick look, seems a lot generated stuff, is it mainly based on the |
Yes, in this case it's editing Let's merge this as is. In the next PR, please update |
what else, than:
|
Nothing actually! I believe that's enough for this PR! I was mislead by the next one, which will imply modifying |
d450fe3
to
655f619
Compare
Ok, also done. ... |
Hey,
next one, also as discussed in #4.
(builds on #13)