Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextpnr: restructure a bit and add pkg images #14

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

se-bi
Copy link
Contributor

@se-bi se-bi commented Jan 17, 2021

Hey,
next one, also as discussed in #4.

(builds on #13)

Copy link
Collaborator

@eine eine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, address the comment below and rebase on top of main. This seems to contain some modifcations from the other PR (already merged).

.github/workflows/nextpnr.yml Outdated Show resolved Hide resolved
@se-bi se-bi force-pushed the update/nextpnr-add-pkg-imgs branch from 815b47d to a9dbd8c Compare January 17, 2021 22:15
@eine
Copy link
Collaborator

eine commented Jan 17, 2021

LGTM. Do you want to handle doc modifications in this same PR, or will be finish the technical modifications first and we will later document all the changes at once?

@se-bi se-bi force-pushed the update/nextpnr-add-pkg-imgs branch from a9dbd8c to d450fe3 Compare January 17, 2021 22:39
@se-bi
Copy link
Contributor Author

se-bi commented Jan 17, 2021

LGTM. Do you want to handle doc modifications in this same PR, or will be finish the technical modifications first and we will later document all the changes at once?

valid point! Though first reaction was kind of 🙈

After a quick look, seems a lot generated stuff, is it mainly based on the doc/tools.yml?

@eine
Copy link
Collaborator

eine commented Jan 17, 2021

After a quick look, seems a lot generated stuff, is it mainly based on the doc/tools.yml?

Yes, in this case it's editing doc/tools.yml and that will update the table. Then, the graph should be updated. That's trickier because the dot source needs to be edited manually.

Let's merge this as is. In the next PR, please update tools.yml; and don't worry about the graph. I'll see how to handle that.

@se-bi
Copy link
Contributor Author

se-bi commented Jan 17, 2021

what else, than:

 nextpnr:
   url: 'https://hdl.github.io/awesome/items/nextpnr'
+  pkg:
+    - 'nextpnr-ice40'
+    - 'nextpnr-ecp5'
+    - 'nextpnr-generic'
   use:
     - 'nextpnr'
     - 'nextpnr:ice40'
     - 'nextpnr:ecp5'
+    - 'nextpnr:generic'

@eine
Copy link
Collaborator

eine commented Jan 17, 2021

Nothing actually! I believe that's enough for this PR! I was mislead by the next one, which will imply modifying impl. Please, push that here.

@se-bi se-bi force-pushed the update/nextpnr-add-pkg-imgs branch from d450fe3 to 655f619 Compare January 17, 2021 23:10
@se-bi
Copy link
Contributor Author

se-bi commented Jan 17, 2021

Ok, also done.

...impl for another time.

@eine eine changed the title Update nextpnr: Restructure a bit and add pkg images nextpnr: restructure a bit and add pkg images Jan 17, 2021
@eine eine merged commit 2f2658b into hdl:main Jan 17, 2021
@eine eine added enhancement New feature or request $R/pkg Related to `$R/pkg` images and their dependencies labels Jan 19, 2021
@se-bi se-bi deleted the update/nextpnr-add-pkg-imgs branch January 19, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request $R/pkg Related to `$R/pkg` images and their dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants