Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2 to 3 migration changes: format strings #6

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

vvvverre
Copy link

Changed all the uses of .format to f-strings instead.
This solves task 2 from Issue #5.

Signed-off-by: Wouter van Verre [email protected]

Changed all the uses of .format to f-strings instead.

Signed-off-by: Wouter van Verre <[email protected]>
Copy link
Collaborator

@michael-etzkorn michael-etzkorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a once over, looks good, just one to go:

return "VerilogParameter('{}')".format(self.name)

I'm new to CI, but I quite like the idea of setting up some small parser tests to sanity check my eyes with PRs like these. So, I'll look to get around to setting something up.

@michael-etzkorn michael-etzkorn mentioned this pull request Jan 25, 2022
4 tasks
@vvvverre
Copy link
Author

vvvverre commented Jan 25, 2022

On a once over, looks good, just one to go:

Good spot! Not sure how I missed that. I've fixed that now.

I'm new to CI, but I quite like the idea of setting up some small parser tests to sanity check my eyes with PRs like these. So, I'll look to get around to setting something up.

I agree. I have little experience with CI either, but happy to help out with setting that up if needed.

@umarcor umarcor merged commit e1153ac into hdl:main Feb 1, 2022
@umarcor
Copy link
Member

umarcor commented Feb 1, 2022

With regard to CI, @Paebels and me gathered some utilities in pyTooling/Actions during the last months. We are using them in the repos from EDA², in vhdl/pyVHDLModel, in repos from pyTooling, etc. So, if you add tests through pytest or tox (which work locally), we might handle them through the reusable workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants