fix: Expand allowed characters in keys #4044 #4045
Conversation
src/languages/yaml.js
Outdated
| { begin: /\w[\w :()\./\-*@]*:(?=[ \t]|$)/ }, | ||
| { // double quoted keys - with brackets | ||
| begin: /"\w[\w :()\./-]*":(?=[ \t]|$)/ }, | ||
| begin: /"\w[\w :()\./\-*@]*":(?=[ \t]|$)/ }, | ||
| { // single quoted keys - with brackets | ||
| begin: /'\w[\w :()\./-]*':(?=[ \t]|$)/ }, | ||
| begin: /'\w[\w :()\./\-*@]*':(?=[ \t]|$)/ }, |
There was a problem hiding this comment.
Awesome!
Can we please keep the - at the very end of the character group so we don't need the extra escape?
Also, could we get a test case added to the markup tests to show that this works as intended?
There was a problem hiding this comment.
@joshgoebel I moved the location of - and created a test file. When running the test, it looks like the picture below, is that right?
There was a problem hiding this comment.
hello! @joshgoebel. Can you please review this part?
|
How are you generating the expect file? All literal quotes need to be HTML escaped. |
|
@joshgoebel I wrote it. expect-test test But it comes out like the picture I posted. |
|
Every |
|
@joshgoebel Test file modification completed. It also passed without any problems. |
|
|
||
| "octo-repo": |
There was a problem hiding this comment.
Why did we lose all the keys?
There was a problem hiding this comment.
@joshgoebel It wasn't a key value that needed to be tested, but a title for that test😂. I was mistaken at first and added that part to the test.
| @@ -20,12 +20,12 @@ export default function(hljs) { | |||
| const KEY = { | |||
There was a problem hiding this comment.
Should we add a look-ahead for : at the end perhaps to make sure these are keys?
There was a problem hiding this comment.
@joshgoebel Should I add it if I think I need it? How should I do it
|
#4105 has solved this slightly more flexibly. Sorry. |
Changes
This modification extends the definition of the key to include spaces, colon, slash, hyphen, and parentheses. It also changes the key to include more character types while maintaining the pattern that ends in colon.
Checklist
CHANGES.md