Skip to content

Commit

Permalink
Added some tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Héctor A. Martos Gómez authored and Héctor A. Martos Gómez committed Sep 9, 2017
1 parent 1ffa8bc commit 5e9887c
Show file tree
Hide file tree
Showing 3 changed files with 180 additions and 0 deletions.
74 changes: 74 additions & 0 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
# Contributor Covenant Code of Conduct

## Our Pledge

In the interest of fostering an open and welcoming environment, we as
contributors and maintainers pledge to making participation in our project and
our community a harassment-free experience for everyone, regardless of age, body
size, disability, ethnicity, gender identity and expression, level of experience,
nationality, personal appearance, race, religion, or sexual identity and
orientation.

## Our Standards

Examples of behavior that contributes to creating a positive environment
include:

* Using welcoming and inclusive language
* Being respectful of differing viewpoints and experiences
* Gracefully accepting constructive criticism
* Focusing on what is best for the community
* Showing empathy towards other community members

Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery and unwelcome sexual attention or
advances
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic
address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a
professional setting

## Our Responsibilities

Project maintainers are responsible for clarifying the standards of acceptable
behavior and are expected to take appropriate and fair corrective action in
response to any instances of unacceptable behavior.

Project maintainers have the right and responsibility to remove, edit, or
reject comments, commits, code, wiki edits, issues, and other contributions
that are not aligned to this Code of Conduct, or to ban temporarily or
permanently any contributor for other behaviors that they deem inappropriate,
threatening, offensive, or harmful.

## Scope

This Code of Conduct applies both within project spaces and in public spaces
when an individual is representing the project or its community. Examples of
representing a project or community include using an official project e-mail
address, posting via an official social media account, or acting as an appointed
representative at an online or offline event. Representation of a project may be
further defined and clarified by project maintainers.

## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported by contacting the project team at [email protected]. All
complaints will be reviewed and investigated and will result in a response that
is deemed necessary and appropriate to the circumstances. The project team is
obligated to maintain confidentiality with regard to the reporter of an incident.
Further details of specific enforcement policies may be posted separately.

Project maintainers who do not follow or enforce the Code of Conduct in good
faith may face temporary or permanent repercussions as determined by other
members of the project's leadership.

## Attribution

This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
available at [http://contributor-covenant.org/version/1/4][version]

[homepage]: http://contributor-covenant.org
[version]: http://contributor-covenant.org/version/1/4/
106 changes: 106 additions & 0 deletions tests/controller-unit-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
/**
* Test for angular-reservation controller
* @author hmartos
*/

'use strict';

describe('angular-reservation controller', function () {

beforeEach(module('hm.reservation'));

describe('Tests', function () {
it('Ensure tests are working', inject(function () {
//Just to test if test runner is working properly
expect(2 + 2).toEqual(4);
expect(2 + 2).not.toEqual(5);
}));
});

describe('ReservationCtrl', function () {
var scope;
var controller;
var serviceMock;
var service;
var factoryMock;
var factory;
var config;
var $q;

beforeEach(inject(function ($rootScope, $controller, $filter, $translate, _reservationAPIFactory_, _reservationConfig_, _reservationService_) {
scope = $rootScope.$new();

//As this is an integration test, here we should inject services and not mocks
service = _reservationService_;
factory = _reservationAPIFactory_;

controller = $controller('ReservationCtrl', {$scope: scope, $filter: $filter, $translate: $translate, reservationAPIFactory: _reservationAPIFactory_, reservationConfig: _reservationConfig_, reservationService: _reservationService_});
}));

it('Is defined', inject(function () {
//Checks that controller is defined
expect(controller).toBeDefined();
}));

describe('Date selection logic', function () {

beforeEach(inject(function ($rootScope, $q) {
var deferred = $q.defer();
spyOn(service, 'onBeforeGetAvailableHours').and.returnValue($q.when()).and.callThrough();

spyOn(factory, 'getAvailableHours').and.returnValue(deferred.promise);//.and.callThrough();

/*spyOn(viewIncidentService, 'listIncidentTypeProcedure').and.returnValue({
then: function (callbackSuccess, callbackError) {
callbackSuccess(ListIncidentTypeProcedure_OUT);
}
});*/

//Call onSelectDate function
controller.onSelectDate();

//TODO Organize this. Uncommented executes getAvailableHours callback
/*deferred.resolve(); //TODO Pass parameters
$rootScope.$digest();
expect(factory.getAvailableHours).toHaveBeenCalled();*/
}));

it('Selected date a valid Date object', inject(function () {
expect(controller.selectedDate instanceof Date).toBeTruthy();
}));

it('Second tab is unlocked', inject(function () {
expect(controller.secondTabLocked).toBeFalsy();
}));


it('Selected tab is now the second tab', inject(function () {
expect(controller.selectedTab).toBe(1);
}));

it('onBeforeAvailableHours service method is called', inject(function () {
expect(service.onBeforeGetAvailableHours).toHaveBeenCalled();
//TODO See toHaveBeenCalledWith()
}));

it('Loader is shown until promise is resolved or rejected an hidden when promised is resolved or rejected', inject(function ($rootScope, $q) {
expect(controller.loader).toBeTruthy();

var deferred = $q.defer();
deferred.resolve();
$rootScope.$digest();

expect(controller.loader).toBeTruthy();
}));

it('getAvailableHours factory method is called', inject(function ($rootScope, $q) {
var deferred = $q.defer();
deferred.resolve();
$rootScope.$digest();
expect(factory.getAvailableHours).toHaveBeenCalled();
//TODO Pass parameters
}));
});

});
});
File renamed without changes.

0 comments on commit 5e9887c

Please sign in to comment.