Support passing encryption in preload #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafintosh
reviewed
Dec 11, 2024
index.js
Outdated
| @@ -261,7 +261,7 @@ class Corestore extends ReadyResource { | |||
| async _preload (opts) { | |||
| if (opts.preload) opts = { ...opts, ...(await opts.preload) } | |||
| await this.ready() | |||
| const conf = { parent: null, sessions: null, ongc: null, core: null } | |||
| const conf = { parent: null, sessions: null, ongc: null, core: null, encryptionKey: null } | |||
There was a problem hiding this comment.
add isBlockKey: false also
mafintosh
added a commit
that referenced
this pull request
Jan 14, 2025
* v7 wip * missing getter on CoreTracker * forward user preload to core * add back sessions and namespaces * missing encryption key * must wait for root in sessions * or null * decode keys * add some compat fields * wait should default to true * root core store closes all cores * switch to rocksdb branch * update package.json * primaryKey can be optionally passed in * global cache * support setNamespace for mutating the ns if you know what you are doing * Fix namespace before ready (#98) * add hanging namespace test * fix deadlock --------- Co-authored-by: Mathias Buus <[email protected]> * add week ref test * kill bootstrap and move to simple from key (#100) * kill bootstrap and move to simple from key * kill more * serial line killer * test for preready sessions * missing close * Session manager (#101) * wip * fix mutation during iteration * move ready down * limit preload usage (#102) * Support passing encryption in preload (#103) * support passing encryption from preload * init isBlockKey also * forward writable option --------- Co-authored-by: Mathias Buus <[email protected]> * pre tag with 7 * cores.get supports buffers * Fix get (#104) * we fixed the wrong typo * add watch/unwatch for monitoring core flows * pin to specific hash tmp * v7 bump to hypercore 11 (#105) * bump to hypercore 11 * updated storage api * remove stale arg * correctly set primary key if parallel * condense * this.primaryKey may be set in constructor * tweak core setup to use alias and fix open * test aliases * docs * also decode dkey since public * basic replication test --------- Co-authored-by: Christophe Diederichs <[email protected]> Co-authored-by: Christophe Diederichs <[email protected]> Co-authored-by: HDegroote <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.