Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs review #7127

Merged
merged 20 commits into from
Sep 2, 2024
Merged

Docs review #7127

merged 20 commits into from
Sep 2, 2024

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Aug 11, 2024

Complements #7126 by fixing what I can fix.

Todo:

  • Remove _extension_name from ESM examples
  • Document you can create layouts with AnyWidgetComponent via get_child.
  • Update layout guides to include AnyWidgetComponent.
  • Add a MarioButton tutorial based on AnyWidgetComponent or ReactComponent.
  • Philipp? Fix React issue identified below.

Not

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.24%. Comparing base (c709832) to head (0ab21ae).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7127   +/-   ##
=======================================
  Coverage   82.23%   82.24%           
=======================================
  Files         335      335           
  Lines       49960    49960           
=======================================
+ Hits        41083    41088    +5     
+ Misses       8877     8872    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Aug 31, 2024

I intended to fix broken links #7087 in this PR. But its grown. So I believe its better to get it reviewed now when its still manageble. Then I hope to fix broken links in another PR.

@MarcSkovMadsen MarcSkovMadsen marked this pull request as ready for review August 31, 2024 15:13
@philippjfr
Copy link
Member

Merging as is for now.

@philippjfr philippjfr merged commit 9446e9b into main Sep 2, 2024
15 of 16 checks passed
@philippjfr philippjfr deleted the fix/esm-review branch September 2, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants