compat: Bokeh 3.7 #7724
Draft
compat: Bokeh 3.7 #7724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7724 +/- ##
==========================================
- Coverage 87.04% 86.60% -0.45%
==========================================
Files 346 346
Lines 52711 52711
==========================================
- Hits 45883 45651 -232
- Misses 6828 7060 +232 ☔ View full report in Codecov by Sentry. |
philippjfr
reviewed
Feb 25, 2025
| @@ -123,7 +123,7 @@ export class HTMLView extends PanelMarkupView { | |||
| return [...super.stylesheets(), html_css] | |||
| } | |||
|
|
|||
| protected rerender() { | |||
There was a problem hiding this comment.
This one scares me and is probably not backward compatible. rerender used to be a panel only thing, seems like there's now a method in Bokeh that probably does something slightly different:
There was a problem hiding this comment.
Yeah, was not sure about this one. If we still want to be backward compatible, can't we just rename the function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bokeh 3.7 RC is soon gonna be released.
This tests the latest dev release to see how much work we need.
EDIT: It is very backward compatible.