Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to subclass components #7730

Merged
merged 4 commits into from
Feb 25, 2025
Merged

Conversation

philippjfr
Copy link
Member

A number of changes to make it easier to subclass component classes:

  • ChatFeed and ChatInterface component types can now be set as class variables
  • Fix issue falsely detecting a non-instance parameter type as a child
  • Fix incorrectly detecting groups on Select widget

These changes are needed for the work on panel-material-ui so I don't have to reimplement entire classes.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (8f9cc0f) to head (af9a6fa).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7730      +/-   ##
==========================================
- Coverage   87.08%   87.08%   -0.01%     
==========================================
  Files         346      346              
  Lines       52711    52716       +5     
==========================================
+ Hits        45904    45908       +4     
- Misses       6807     6808       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 2da70d6 into main Feb 25, 2025
18 checks passed
@philippjfr philippjfr deleted the subclass_improvements branch February 25, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant