Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings->Entities: set width for "Status" #23975

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ildar170975
Copy link
Contributor

Breaking change

Proposed change

before:

изображение

изображение

изображение

after:

изображение

изображение

изображение

Definitely for some languages the min-width: 80px might not be enough.
Let's fix it for English at least.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ildar170975 ildar170975 marked this pull request as ready for review January 31, 2025 03:03
@ildar170975 ildar170975 changed the title Settings->Entities: set min-width for "Status" Settings->Entities: set width for "Status" Jan 31, 2025
@@ -353,6 +353,8 @@ export class HaConfigEntities extends SubscribeMixin(LitElement) {
showNarrow: true,
sortable: true,
filterable: true,
minWidth: "80px",
maxWidth: "80px",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add maxWidth though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants