Fix early Sentry reporting

[agners]

Proposed change

If an exception occures between when Sentry gets initialized and the Supervisor state is first set to INITIALIZED (which is only later the case in coresys.core.connect()), the error filtering tries to collect context which is not ready yet. Make sure that we exit filtering early just like in the INITIALIZED state.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (which adds functionality to the supervisor)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:
• Link to cli pull request:
• Link to client library pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Ruff (ruff format supervisor tests)
• Tests have been added to verify that the new code works.

If API endpoints or add-on configuration are added/changed:

• Documentation added/updated for developers.home-assistant.io
• CLI updated (if necessary)
• Client library updated (if necessary)

Summary by CodeRabbit

• Bug Fixes
  • Improved event processing logic by expanding the condition under which events are handled, ensuring smoother and more predictable behavior when the system is in an undefined state.

[coderabbitai]

📝 Walkthrough

Walkthrough

The change updates the filter_data function in the supervisor/misc/filter.py file. It modifies the condition that determines when the function should return the input event. Previously, the function returned early only if the system state was either CoreState.INITIALIZE or CoreState.SETUP. The new change adds a check for None as an acceptable state, allowing the function to bypass additional processing when the state is None as well.

Changes

File	Change Summary
supervisor/misc/filter.py	Modified the conditional check in filter_data to include None as a valid state alongside INITIALIZE and SETUP.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant FilterFunc as filter_data
    Caller->>FilterFunc: Call filter_data(event)
    alt Valid state (INITIALIZE, SETUP, or None)
        FilterFunc-->>Caller: Return event (early exit)
    else Other states
        FilterFunc->>FilterFunc: Proceed with further processing
        FilterFunc-->>Caller: Return processed event
    end

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5d4ebc and 82ef62e.

📒 Files selected for processing (1)

• supervisor/misc/filter.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Build armv7 supervisor
• GitHub Check: Build armhf supervisor
• GitHub Check: Build aarch64 supervisor
• GitHub Check: Run tests Python 3.13.2

🔇 Additional comments (1)

supervisor/misc/filter.py (1)

63-63: Excellent fix for the early Sentry reporting issue.

This change correctly addresses the issue described in the PR objectives. By adding None to the conditional check, the filter_data function will now exit early when the core state hasn't been initialized yet, preventing attempts to collect context information that isn't available during the early stages of initialization.

This modification ensures that Sentry error reporting works properly even when an exception occurs between Sentry initialization and when the Supervisor state is set to INITIALIZED.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[agners]

Superseeded by #5686.