-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Sentry asyncio integration #5685
Conversation
Enable the Sentry asyncio integration. This makes sure that exception in non-awaited tasks get reported to sentry. While at it, use partial instead of lambda for the filter function.
📝 WalkthroughWalkthroughThe change updates the Sentry integration in the supervisor module by importing asynchronous support and cleaning up the event filtering. The new import of Changes
Sequence Diagram(s)sequenceDiagram
participant Supervisor as Supervisor Module
participant SentrySDK as Sentry SDK
participant Filter as filter_data
Supervisor->>SentrySDK: Initialize sentry_sdk.init (with AsyncioIntegration and before_send)
SentrySDK->>Filter: Invoke before_send (partial(filter_data, coresys))
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🔇 Additional comments (4)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Proposed change
Enable the Sentry asyncio integration. This makes sure that exception in non-awaited tasks get reported to sentry.
While at it, use partial instead of lambda for the filter function.
Type of change
Additional information
Checklist
ruff format supervisor tests
)If API endpoints or add-on configuration are added/changed:
Summary by CodeRabbit