This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for ASP.NET Core 3.0 while maintaining compatibility for 2.2.
Whether you want to support both is obviously up to you, but this makes it possible 🙂
The .NET Core 3.0 SDK complains about the obsolete
<PackageLicenseUrl>
element now, so I've updated it to use<PackageLicenseExpression>
instead.Tests all pass, but I haven't run the integration tests (I'll leave that to you)
As a point of interest - your package dependencies currently tie you to ASP.NET Core 2.2 which doesn't support .NET Framework, so multi targeting
net461
makes no sense 🙂I'd suggest you either drop the
net461
target to make your life a bit simpler (as it can never be used), or lower the package dependencies to ASP.NET Core 2.1, which is an LTS release and is the only place supported to run on .NET Framenwork. That's a separate issue to this PR though!