Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create patterns notebook #182

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

agustin-vaca
Copy link
Collaborator

No description provided.

@jyoung3131
Copy link
Contributor

Hi @agustin-vaca - this is looking good so far. I noticed one hard-coded link to your nethome for Quicksilver, which we might need to generalize.

For this PR, can I ask you to add some basic command-line testing capability using nbmake and pytest?

As a separate BASH script is fine for now - our goal is to get these into our normal CI testing framework so we can make sure changes with the refactor don't break the notebook.

https://semaphoreci.com/blog/test-jupyter-notebooks-with-pytest-and-nbmake

  1. Create a venv in the script using Python 3.9 or 3.10 (see here for a reference: https://gt-crnch-rg.readthedocs.io/en/main/general/python-environments.html)
  2. pip install pytest
  3. check errors on a CRNCH node to see if they make sense.
  4. You can skip the semaphore and other integration since we will use GH actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants